`bazelisk build -c dbg :openroad --keep_going` fails to link

[oharboe]

Description

$ bazelisk build -c dbg :openroad --keep_going
INFO: Analyzed target //:openroad (0 packages loaded, 0 targets configured).
ERROR: /home/oyvind/OpenROAD-flow-scripts/tools/OpenROAD/BUILD.bazel:115:10: Linking openroad failed: (Exit 1): cc_wrapper.sh failed: error executing CppLink command (from target //:openroad) external/toolchains_llvm~~llvm~llvm_toolchain/bin/cc_wrapper.sh @bazel-out/k8-dbg/bin/openroad-2.params

Use --sandbox_debug to see verbose messages from the sandbox and retain the sandbox build root for debugging
ld.lld: error: undefined symbol: std::__glibcxx_assert_fail(char const*, int, char const*, char const*)
>>> referenced by atomic_base.h:498 (/usr/lib/gcc/x86_64-linux-gnu/15/../../../../include/c++/15/bits/atomic_base.h:498)
>>>               bazel-out/k8-dbg/bin/external/edu_berkeley_abc/_objs/abc-lib/utilPth.pic.o:(std::atomic<bool>::load(std::memory_order) const)
>>> referenced by atomic_base.h:499 (/usr/lib/gcc/x86_64-linux-gnu/15/../../../../include/c++/15/bits/atomic_base.h:499)
>>>               bazel-out/k8-dbg/bin/external/edu_berkeley_abc/_objs/abc-lib/utilPth.pic.o:(std::atomic<bool>::load(std::memory_order) const)
>>> referenced by atomic_base.h:473 (/usr/lib/gcc/x86_64-linux-gnu/15/../../../../include/c++/15/bits/atomic_base.h:473)
>>>               bazel-out/k8-dbg/bin/external/edu_berkeley_abc/_objs/abc-lib/utilPth.pic.o:(std::atomic<bool>::store(bool, std::memory_order))
>>> referenced 2 more times
clang: error: linker command failed with exit code 1 (use -v to see invocation)
INFO: Found 1 target...
Target //:openroad failed to build
Use --verbose_failures to see the command lines of failed build steps.
INFO: Elapsed time: 6.029s, Critical Path: 5.76s
INFO: 2 processes: 2 internal.
ERROR: Build did NOT complete successfully

Workaround:

bazelisk build --cxxopt=-stdlib=libstdc++ --linkopt=-lstdc++ -c dbg :openroad

Suggested Solution

No response

Additional Context

No response

[oharboe]

@hzeller @QuantamHD Ideas?

[QuantamHD]

It looks like this file is trying to distinguish between c++ and c. I added -x c++ to all the abc files in bazel rules maybe it needs some kind of link flag since these are c files.

[QuantamHD]

Perhaps it wants a -latomic in the link opts? https://github.com/hdl/bazel_rules_hdl/blob/main/dependency_support/edu_berkeley_abc/bundled.BUILD.bazel#L1220

[oharboe]

Perhaps it wants a -latomic in the link opts? https://github.com/hdl/bazel_rules_hdl/blob/main/dependency_support/edu_berkeley_abc/bundled.BUILD.bazel#L1220

Mucked around with that, couldn't get it to work, same linker error.

diff --git a/WORKSPACE b/WORKSPACE
index 30963dbf73..f58940f2bd 100644
--- a/WORKSPACE
+++ b/WORKSPACE
@@ -12,15 +12,20 @@ rules_hdl_git_hash = "4bfc8987e521f2002e7b898ba94d3df4c6204913"
 
 rules_hdl_git_sha256 = "227ac0288299f2b0f31a188113cef9f733258398fd616215275bddab1e43d019"
 
-http_archive(
+# http_archive(
+#     name = "rules_hdl",
+#     sha256 = rules_hdl_git_sha256,
+#     strip_prefix = "bazel_rules_hdl-%s" % rules_hdl_git_hash,
+#     urls = [
+#         "https://github.com/hdl/bazel_rules_hdl/archive/%s.tar.gz" % rules_hdl_git_hash,
+#     ],
+# )
+local_repository(
     name = "rules_hdl",
-    sha256 = rules_hdl_git_sha256,
-    strip_prefix = "bazel_rules_hdl-%s" % rules_hdl_git_hash,
-    urls = [
-        "https://github.com/hdl/bazel_rules_hdl/archive/%s.tar.gz" % rules_hdl_git_hash,
-    ],
+    path = "../../../bazel_rules_hdl",
 )

$ git diff
diff --git a/dependency_support/edu_berkeley_abc/bundled.BUILD.bazel b/dependency_support/edu_berkeley_abc/bundled.BUILD.bazel
index a804cfa..9ab9586 100644
--- a/dependency_support/edu_berkeley_abc/bundled.BUILD.bazel
+++ b/dependency_support/edu_berkeley_abc/bundled.BUILD.bazel
@@ -1219,6 +1219,7 @@ cc_library(
         "-Wno-constant-logical-operand",
         "-x c++",
         "-std=c++17",
+        "-Wl,-latomic",
     ],
     defines = [
         "LIN64",
@@ -1232,7 +1233,8 @@ cc_library(
         "ABC_NAMESPACE=abc",
     ],
     includes = ["src/"],
-    linkopts = ["-ldl", "-lpthread"],
+    linkopts = ["-ldl", "-lpthread",         "-latomic",
+],
     linkstatic = True,
     textual_hdrs = glob(
         [

[oharboe]

From copilot:

The error indicates that the linker (ld.lld) is unable to resolve the symbol std::__glibcxx_assert_fail, which is part of the GNU C++ Standard Library implementation (libstdc++). This issue typically arises due to a mismatch between the compiler and the standard library being used, or because the correct standard library is not linked.

If you are using Clang as the compiler, ensure that it is configured to use the correct C++ standard library (libstdc++ or libc++).

Trying:

bazelisk build --cxxopt=-stdlib=libstdc++ --linkopt=-lstdc++ -c dbg :openroad --keep_going

Fixes needed: https://github.com/The-OpenROAD-Project/OpenROAD/pull/7357

Still fails:

INFO: Analyzed target //:openroad (0 packages loaded, 0 targets configured).
ERROR: /home/oyvind/OpenROAD-flow-scripts/tools/OpenROAD/src/odb/src/def/BUILD:50:11: Compiling src/odb/src/def/def/def_parser.cpp failed: (Exit 1): cc_wrapper.sh failed: error executing CppCompile command (from target //src/odb/src/def:def_bison_lib) external/toolchains_llvm~~llvm~llvm_toolchain/bin/cc_wrapper.sh -U_FORTIFY_SOURCE '--target=x86_64-unknown-linux-gnu' -U_FORTIFY_SOURCE -fstack-protector -fno-omit-frame-pointer -fcolor-diagnostics ... (remaining 46 arguments skipped)

Use --sandbox_debug to see verbose messages from the sandbox and retain the sandbox build root for debugging
bazel-out/k8-dbg/bin/src/odb/src/def/def/def_parser.cpp:2340:1: error: redundant #include of module 'crosstool./usr/include' appears within namespace 'DefParser' [-Wmodules-import-nested-redundant]
 2340 | #  include <stdio.h> /* INFRINGES ON USER NAME SPACE */

[oharboe]

Trying:

bazelisk build --cxxopt=-stdlib=libc++ --linkopt=-lc++ -c dbg :openroad

Same result:

ERROR: /home/oyvind/OpenROAD-flow-scripts/tools/OpenROAD/BUILD.bazel:115:10: Linking openroad failed: (Exit 1): cc_wrapper.sh failed: error executing CppLink command (from target //:openroad) external/toolchains_llvm~~llvm~llvm_toolchain/bin/cc_wrapper.sh @bazel-out/k8-dbg/bin/openroad-2.params

Use --sandbox_debug to see verbose messages from the sandbox and retain the sandbox build root for debugging
ld.lld: error: undefined symbol: std::__glibcxx_assert_fail(char const*, int, char const*, char const*)
>>> referenced by atomic_base.h:498 (/usr/lib/gcc/x86_64-linux-gnu/15/../../../../include/c++/15/bits/atomic_base.h:498)
>>>               bazel-out/k8-dbg/bin/external/edu_berkeley_abc/_objs/abc-lib/utilPth.pic.o:(std::atomic<bool>::load(std::memory_order) const)
>>> referenced by atomic_base.h:499 (/usr/lib/gcc/x86_64-linux-gnu/15/../../../../include/c++/15/bits/atomic_base.h:499)
>>>               bazel-out/k8-dbg/bin/external/edu_berkeley_abc/_objs/abc-lib/utilPth.pic.o:(std::atomic<bool>::load(std::memory_order) const)
>>> referenced by atomic_base.h:473 (/usr/lib/gcc/x86_64-linux-gnu/15/../../../../include/c++/15/bits/atomic_base.h:473)
>>>               bazel-out/k8-dbg/bin/external/edu_berkeley_abc/_objs/abc-lib/utilPth.pic.o:(std::atomic<bool>::store(bool, std::memory_order))
>>> referenced 2 more times
clang: error: linker command failed with exit code 1 (use -v to see invocation)
INFO: Found 1 target...

[oharboe]

Pinata programming: this now produces a debug build... https://github.com/The-OpenROAD-Project/OpenROAD/pull/7358

[oharboe]

@QuantamHD @maliberty FYI, I get the same problem now with bazelisk build :openroad; use-case bisection.

This works:

bazelisk build --cxxopt=-stdlib=libstdc++ --linkopt=-lstdc++ :openroad

[oharboe]

@hzeller Any new insights on this one?

[maliberty]

Why --cxxopt=-stdlib=libstdc++ --linkopt=-lstdc++ ?

[oharboe]

Why --cxxopt=-stdlib=libstdc++ --linkopt=-lstdc++ ?

A workaround that's good 'nuf to use for local testing.

https://github.com/The-OpenROAD-Project/OpenROAD/issues/7349

[maliberty]

bazelisk build -c dbg //:openroad builds without error on eebcc18972ca47174e7af6904dd552efa3572cf6 for me.

[oharboe]

bazelisk build -c dbg //:openroad builds without error on eebcc18 for me.

Yes, some hermeticity is missing, it would seem. It will work on some platforms and others not.