Ethan Mahintorabi

Results 203 comments of Ethan Mahintorabi

@RTimothyEdwards Still need to the license headers before this can be merged. Also are there any CI tests available today? If not that's fine I'll still merge it

Alright, is it Efabless' or Tim Edward's copyright?

This feels like a dangerous change to me. Not all users have a tmp folder, and using a time based file name is also a bit dangerous if you have...

I like that change a lot better. > > This feels like a dangerous change to me. Not all users have a tmp folder, and using a time based file...

Seems like it worked for me. ``` ================== WARNING: ThreadSanitizer: data race (pid=565408) Write of size 8 at 0x7b0800023b20 by thread T4: #0 free (openroad+0x3642129) (BuildId: 3deff8356d73a0bbe4bc685322ea5f6f7ab77349) #1 (libglib-2.0.so.0+0x56f2e) (BuildId:...

This one seems interesting ``` ================== ================== WARNING: ThreadSanitizer: data race (pid=565408) Atomic read of size 1 at 0x7b0c000355b0 by main thread: #0 pthread_mutex_lock (openroad+0x364541f) (BuildId: 3deff8356d73a0bbe4bc685322ea5f6f7ab77349) #1 dbus_connection_get_is_connected (libdbus-1.so.3+0x1593a)...

@oharboe I modified the ASAN options, and then compiled with `CC=clang CXX=clang++ cmake -DCMAKE_BUILD_TYPE=Debug -DASAN=ON -GNinja .. && ninja` ![Image](https://github.com/The-OpenROAD-Project/OpenROAD/assets/3784748/49ab18a0-35ed-4d94-833e-a44bba8f2f93)

This one occured after reading a db ``` WARNING: ThreadSanitizer: data race (pid=571606) Read of size 1 at 0x7b7000051ef0 by thread T9 (mutexes: write M0): #0 gui::RenderThread::draw(QImage&, QRect const&, std::set...

Looks like restart_ is potentially not protected by a mutex. /usr/local/google/home/ethanmoon/OpenROAD/src/gui/src/renderThread.cpp:150:14 ``` if (!isRunning()) { start(LowPriority); } else { restart_ = true; condition_.wakeOne(); } ``` vs /usr/local/google/home/ethanmoon/OpenROAD/src/gui/src/renderThread.cpp:104:14 ``` mutex_.lock(); if...