Jeff Kinard

Results 36 comments of Jeff Kinard

> Can we just install it using GitHub's action? like > > https://github.com/GoogleCloudPlatform/DataflowTemplates/blob/55dcefc6baf0ef135bc3dea3770328dda74fe109/.github/actions/setup-env/action.yml#L53 Does that work on self-hosted machines? I would assume there are permission issues with installing. Either way,...

@joewxboy No, I am no longer working on this. I went ahead and unassigned myself.

Needs a larger design discussion. Moving to draft for now.

@robertwb All comments addressed and rebased on master

> Looks like you need to add an apache license preamble to sdks/python/apache_beam/yaml/examples/README.md to make RAT happy. Are the other tests known issues? I don't see how my PR is...

@robertwb Finally got the tests green. The `RowCoderTest` imports `beam`, which imports the `examples_test.py` file I added, which *used* to import `main.py`. In `main.py`, there is the line `LogicalType.register_logical_type(MillisInstant)` -...

@damccorm I have another PR I want to get in before refactoring this. Should open that one today

> Could you also make the same changes to the DatastreamToSpanner template IT as well? https://github.com/GoogleCloudPlatform/DataflowTemplates/blob/main/v2/datastream-to-spanner/src/main/java/com/google/cloud/teleport/v2/templates/DataStreamToSpanner.java > > This template had the staging tests present in the internal python based...