Jeff Kinard
Jeff Kinard
.take-issue
Wait on https://github.com/GoogleCloudPlatform/DataflowTemplates/actions/runs/9701763738 to pass as well (validates 2.57.0 upgrade with Spanner PR)
@fbiville Running the IT's with the imported resource manager still fails... not sure if there is something I am missing, but it may not be worth investing too much time...
@fbiville apologies for the delay. I went ahead and refactored to use the RM from Beam 2.57 since the repo has now been updated to that version. Let me know...
You should be able to rebase on master now and pull in the EnrichmentTransform changes
> @robertwb @Polber can I take this issue ? @mravi Feel free to take this on! Thanks
R: @robertwb
> #1674 @manitgupta #1674 added a line to make all ITs use GCS notifications https://github.com/GoogleCloudPlatform/DataflowTemplates/blob/main/v2/datastream-to-spanner/src/test/java/com/google/cloud/teleport/v2/templates/DataStreamToSpannerIT.java#L384 So either that change should be reverted, or this PR should remove the redundant tests
@damccorm It's also hard to test because new caches get created by other workflows which affect this one being able to use AR packages instead of maven central. Once it...
Test failure looks unrelated