beam icon indicating copy to clipboard operation
beam copied to clipboard

[yaml] Add Beam YAML Examples and Getting started docs

Open Polber opened this issue 1 year ago • 3 comments

Please add a meaningful description for your change here


Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:

  • [ ] Mention the appropriate issue in your description (for example: addresses #123), if applicable. This will automatically add a link to the pull request in the issue. If you would like the issue to automatically close on merging the pull request, comment fixes #<ISSUE NUMBER> instead.
  • [ ] Update CHANGES.md with noteworthy changes.
  • [ ] If this contribution is large, please file an Apache Individual Contributor License Agreement.

See the Contributor Guide for more tips on how to make review process smoother.

To check the build health, please visit https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md

GitHub Actions Tests Status (on master branch)

Build python source distribution and wheels Python tests Java tests Go tests

See CI.md for more information about GitHub Actions CI or the workflows README to see a list of phrases to trigger workflows.

Polber avatar Jan 12 '24 19:01 Polber

R: @robertwb

Polber avatar Jan 12 '24 19:01 Polber

Stopping reviewer notifications for this pull request: review requested by someone other than the bot, ceding control

github-actions[bot] avatar Jan 12 '24 19:01 github-actions[bot]

Any update on this?

robertwb avatar Feb 12 '24 22:02 robertwb

@robertwb All comments addressed and rebased on master

Polber avatar Feb 22 '24 21:02 Polber

Looks like you need to add an apache license preamble to sdks/python/apache_beam/yaml/examples/README.md to make RAT happy.

robertwb avatar Feb 29 '24 16:02 robertwb

Looks like you need to add an apache license preamble to sdks/python/apache_beam/yaml/examples/README.md to make RAT happy.

Are the other tests known issues? I don't see how my PR is affecting huggingface and rowcoder tests

Polber avatar Feb 29 '24 16:02 Polber

Perhaps rebasing will get to green if there were issues on master?

kennknowles avatar Mar 04 '24 16:03 kennknowles

I kicked off some re-runs, but I'm not sure if it always rebases on head. +1 to merging with master and re-pushing if this doesn't get things green.

robertwb avatar Mar 04 '24 23:03 robertwb

I think it does not. The various merge and HEAD commits associated with a PR are, I think, only updated when the head commit of the PR changes. So reruns will be against the same commit. (I could have this wrong, of course)

kennknowles avatar Mar 05 '24 17:03 kennknowles

@robertwb

Finally got the tests green.

The RowCoderTest imports beam, which imports the examples_test.py file I added, which used to import main.py. In main.py, there is the line LogicalType.register_logical_type(MillisInstant) - This overrided the MicrosInstant that RowCoderTest requires to pass.

I adjusted the test to run yaml_transform.expand_pipeline instead, which fixed that issue. I also realized that the examples tests were not actually running on presubmits, so I added several fixes to get them running and green.

Polber avatar Mar 08 '24 15:03 Polber

Thanks. Nice to finally get this in.

robertwb avatar Mar 08 '24 21:03 robertwb