DataflowTemplates icon indicating copy to clipboard operation
DataflowTemplates copied to clipboard

Install python3.11 on gitactions runners

Open Polber opened this issue 10 months ago • 4 comments

Adds installation of python 3.11 to startup script for gitactions runners

Polber avatar Apr 16 '24 18:04 Polber

Can we just install it using GitHub's action? like https://github.com/GoogleCloudPlatform/DataflowTemplates/blob/55dcefc6baf0ef135bc3dea3770328dda74fe109/.github/actions/setup-env/action.yml#L53

damccorm avatar Apr 16 '24 18:04 damccorm

Can we just install it using GitHub's action? like

https://github.com/GoogleCloudPlatform/DataflowTemplates/blob/55dcefc6baf0ef135bc3dea3770328dda74fe109/.github/actions/setup-env/action.yml#L53

Does that work on self-hosted machines? I would assume there are permission issues with installing. Either way, this is just a quick fix for a failing test, and follows the pattern of the rest of the startup script. Perhaps refactoring all the startup actions in the future would be better, but I'm not sure that is worth the time investment right now

Polber avatar Apr 16 '24 18:04 Polber

It does work (that's also how we install java https://github.com/GoogleCloudPlatform/DataflowTemplates/blob/55dcefc6baf0ef135bc3dea3770328dda74fe109/.github/actions/setup-java-env/action.yml#L43 which runs against self-hosted, and we run the actions I linked as part of the release workflow - https://github.com/GoogleCloudPlatform/DataflowTemplates/blob/55dcefc6baf0ef135bc3dea3770328dda74fe109/.github/workflows/release.yml#L67).

follows the pattern of the rest of the startup script.

I don't think we install any languages here.


I'd vote we update to use setup-python next to setup-go in setup-env/action.yml in order to be consistent/have a single place where we configure language versions for CI. Its also less custom code to take care of and will handle all your things like env vars for you.

damccorm avatar Apr 16 '24 18:04 damccorm