David Maas

Results 177 comments of David Maas

`VTableLayout` contains an `AddressPoints` map. This is probably what we need. This issue is closely related to https://github.com/InfectedLibraries/Biohazrd/issues/112

A prototype of this was added as [`Biohazrd.Transformation.__TypeReferenceVisitor`](https://github.com/InfectedLibraries/Biohazrd/commit/1118c2d8cf04ed9dce4f5ba41359f3880c10eb06#diff-a948984190ed26dceb5a9e35c6fce5ffd283785f3cd71d31148aaebc0b1c0c43) as part of https://github.com/InfectedLibraries/Biohazrd/issues/188 It's not 100% there and is missing extensibility points, but it accomplishes the needs of https://github.com/InfectedLibraries/Biohazrd/issues/188 for now.

Reminder for the future since it's kinda burried above: The main issue is that `TypeReferenceVisitor` can't use the same logic for enumerating type references as `DeclarationVisitor` does. I think the...

Once this is fixed make sure to re-enable the broken tests in `FunctionAbiTests`.

Consider also supporting this with Linux ELF `.o` and Windows COFF `.obj` files since it would not be substantially more complex to add them. (Especially for Linux ELF `.o` since...

To answer your question directly: I don't know when I'll have time to visit this properly since it's not a very high priority for me or any of my sponsors...

Minor tweaks that should be done to the default order used in infected libraries today: * `CSharpBuiltinTypeTransformation` should be right after `CSharpTypeReductionTransformation`. * `DeduplicateNamesTransformation` should be last before `CSharpTranslationVerifier`. -...

Wrote a test for this issue. Even though `ConstOverloadRenameTransformation` is for method const-ness, I think it makes sense to someone who isn't a C++ spec nerd to expect it to...

> (Note to self: See notes for some details on how this is implemented in various ABIs.) I'm sure those notes are still *somewhere*, lol. I ended up digging around...

`LinkImportsTransformation` makes this significantly less important as it will emit errors that it can't resolve the inline methods. It'd still be nice if we emitted an actionable error with a...