David Maas

Results 177 comments of David Maas

It's somehow not mentioned above, but parameterless constructors are coming to C# 10 so that solves the main reason I hadn't actually done this yet. Julien Couvreur confirmed they should...

The cumulative changes being made for https://github.com/InfectedLibraries/Biohazrd/issues/198 simplify our ability to do this since `EmitFunctionParameterList` is emitting the parameters for vtable function pointers.

Oddly enough, using `MarshalAs(I1)` for bools doesn't trigger `MarshalDirectiveException` even when marshaling is disabled. Not sure if that's intentional but I'd still like to eliminate it either way.

`MarshalAs` for return values and parameters has been eliminated as part of https://github.com/MochiLibraries/Biohazrd/issues/233 and https://github.com/MochiLibraries/Biohazrd/issues/236 While working on these, it dawned on me that emitting `MarshalAs(I1)` on fields may not...

The newly added `AutoNameUnnamedParametersTransformation` makes this situation slightly less obnoxious. I do still want to investigate whether Clang automagically associates these comments with the parameter or not. (Maybe at the...

Another place where this might be nice to have is the verification stage. `CSharpTranslationVerifier` is slowly becoming a mess of unrelated concerns, it might be nice to try and break...

~~Instead of keeping track of slot numbers, let's change `TranslatedVTableEntry` to refer to the `TranslatedFunction` it corresponds to using https://github.com/InfectedLibraries/Biohazrd/issues/150 instead.~~ This issue is actually about something different than I...

Note: This is *not* what `PathogenVTableEntry.Offset` provides. That's specifically only relevant for `VCallOffset`, `VBaseOffset`, and `OffsetToTop` entries.

We can fudge this without it, but it'd be a good idea to do this at the same time as https://github.com/InfectedLibraries/Biohazrd/issues/49

In the Itanium ABI, this entry is called the address point. The logic we use for determining the 0th entry lines up with the Itanium spec (0th entry is first...