David Maas

Results 177 comments of David Maas

Interesting case that came up with for this: https://github.com/ocornut/imgui/blob/839ecce57154a33ede985eeab746828f8102c8d9/imgui_internal.h#L1293 `ImDockRequest` is not defined in `imgui_internal.h`, It's defined in `imgui.cpp`: https://github.com/ocornut/imgui/blob/839ecce57154a33ede985eeab746828f8102c8d9/imgui.cpp#L12090-L12111 However, `ImVector` does not depend on `T` for its layout,...

For the sake of limiting bus factor, here's `WindowsSdkHelper` mentioned above: https://gist.github.com/PathogenDavid/29794af32ac1c88fdd489d27a2debb39 It doesn't actually override what Clang uses using environment variables but instead uses `--no-standard-includes` and `-isystem` based on...

This issue is somewhat at odds with the fact that for some libraries we have [the following pattern](https://github.com/InfectedLibraries/InfectedImGui/blob/f98be6aab6438d4881023d7533db601aadb43631/InfectedImGui.Generator/Program.cs#L126-L144): 1. Run `InlineExportHelper` 2. Rebuild the native components 3. Run `LinkImportsTransformation` The...

Another possibility is recommend people who need this capability do their main development on Windows and provide support for the native rebuild happening in WSL. -- The WSL components are...

We should also generate `GetEnumerator` on declarations which have translated declarations as children.

Some C++ compilers will sometimes generate an implicit constructor to handle this. For example, `x86-64 clang 10.0.0` on Godbolt produces: ```asm Test(): # @Test() push rbp mov rbp, rsp sub...

This is blocking the use of `PxDefaultAllocator` in PhysX. We should just leverage the inline export helper infrastructure for this.

Turns out this will be a bit of a pain since we can't synthesize `TranslatedFunction`s and `InlineExportHelper` assumes we have a `ClanSharp.FunctionDecl. We'll probably need to add synthesizing functions (which...

I added a warning to `CSharpTranslationVerifier` to help alert people to this missing feature and to make it easier to enumerate the types affected by it. (Although ideally we should...

`TranslatedFunction` types should likely never be allowed because we can't arrange the function call to them for ABI handling purposes.