Tobias Nyholm

Results 325 comments of Tobias Nyholm

Hehe. Im not super happy with HTTPlug's exceptions either =) What is the point of `TransferException`? All exceptions implements the `GuzzleException` interface so you can use it if you want...

> But what if you don't want to catch Guzzle exceptions not caused by the actual HTTP request-response stuff? Im not sure I 100% understand. Could you rephrase that without...

And FYI: The `TransferException` class is never used in Guzzle. It is only referred to here: ```php class RequestException extends TransferException implements RequestExceptionInterface ``` ---------- @sagikazarmark: So if the request...

I've updated my first entry to this issue. It is now: ``` \InvalidArgumentException -- InvalidArgumentException \RuntimeException -- RequestException -- TooManyRedirectsException -- NetworkException -- BadResponseException -- -- ClientException -- -- ServerException...

I saw that you added that in your suggestion. I dont think we should have our own RuntimeException because we are never throwing one, we do however throw a InvalidArgumentException.

I dont follow the specifications discussions too carefully, but isn't H2 push considered as a misstake? Ie, it is cool and all, but it is not as useful and we...

Could you please provide a reproducer script? Or maybe even a test case?

Lets merge this to a separate branch. `v2` That will "solve" https://github.com/OskarStark/php-cs-fixer-ga/issues/17. A user can then do the followng to always get the latest php-cs-fixer. ```yaml - name: PHP-CS-Fixer uses:...

I think sending emails is a bit out of scope. But I do like the process. We should support such process by including a status command (#52). The CI can...

I like the ability of a support function. This is however only a xliff feature. But xliff is the standard =) 👍 To implement this we need to make changes...