Tobias Nyholm

Results 325 comments of Tobias Nyholm

Cool. Can we focus on finishing this PR this week or next? @liarco, could you rebase your PR and make sure Travis (2/3) and Fabbot.io is green?

Oops. Sorry. I see your comment about the CI... Good. Dont make fabbot green =) Could you rebase please?

Thank you. Could you add a test for this please? Also make sure Fabbot is happy.

@derrabus is correct. You could fix that by adding Finder in the require-dev section. Or even better, use the `glob()` to avoid the extra dependency.

I can confirm this issue. It happens because we cannot normalize `RawMessage` from Mime component. It has a constructor with required arguments. We need to use a serializer with the...

Thank you for reporting the issue still exists. I would be happy to review a PR that fixes this issue. Im sure that everybody knows that "open source software" means...

Thank you. Could you help me understand why https://github.com/symfony/symfony/commit/87f328428e76b9b76deeaa70df5ad34c88a4d5f7 wasn't a fix for this problem? Also, do you have any suggestions for what actually will fix the issue?

The `SendEmailMessage` is used in [EmailChannel](https://github.com/symfony/symfony/blob/b66368a9e23ca92c5bdd50beddc940dd05f2c981/src/Symfony/Component/Notifier/Channel/EmailChannel.php#L82) and in [Mailer](https://github.com/symfony/symfony/blob/fc4be4822a75e1f2697a260d6ba16ea8bfdfbe1f/src/Symfony/Component/Mailer/Mailer.php#L54). Narrowing the constructor parameter would be a BC break. :(

This is not a bug in the Mailer, it is an issue in the `JsonSerializer`. I'll open a new issue.

> To be honest, I would recommend using API Platform instead of adding such code to Symfony. I've been using this feature for a few months now. I must say...