php-cs-fixer-ga icon indicating copy to clipboard operation
php-cs-fixer-ga copied to clipboard

Use always newest version of php-cs-fixer

Open alexander-schranz opened this issue 5 years ago • 8 comments
trafficstars

I would use the newest version or make it configureable which version it should use and make it possible to use always the latest version.

alexander-schranz avatar Feb 17 '20 16:02 alexander-schranz

currently it is „configurable“ via the docker tag which is based on the release on github.

OskarStark avatar Feb 17 '20 18:02 OskarStark

@OskarStark Okay so this releases are greated automatically?

alexander-schranz avatar Feb 17 '20 19:02 alexander-schranz

Unfortunately not, I do this whenever a new release is created 👎🏻 Automating this would be very nice, but I don’t know how

OskarStark avatar Feb 17 '20 19:02 OskarStark

Lets merge this to a separate branch. v2

That will "solve" https://github.com/OskarStark/php-cs-fixer-ga/issues/17. A user can then do the followng to always get the latest php-cs-fixer.

- name: PHP-CS-Fixer
        uses: OskarStark/php-cs-fixer-ga@v2
        with:
          args: --dry-run --diff-format udiff

There will be more maintenance cost to merge features into 2 branches. But Im not sure how many features that is usually added to this lib.

Nyholm avatar Apr 16 '20 09:04 Nyholm

TBH I don't understand the problem here. using @master will always use the latest version of PHP-CS-Fixer

For a specific version you can use it, it gets tagged automatically on dockerhub.

OskarStark avatar Apr 16 '20 19:04 OskarStark

I agree with @OskarStark this PR is not needed, just that maintainer needs to keep on to push over @master each time the new version is updated.

however, I like the @v2 tag proposed by @Nyholm, to be somewhat semver compatible, in case php-cs-fixer v3 appears.

glensc avatar Oct 09 '20 04:10 glensc

Unfortunately not, I do this whenever a new release is created 👎🏻 Automating this would be very nice, but I don’t know how

We can do it via a GitHub action but it requires some implementation effort ofc..

fabiofdsantos avatar Jul 21 '22 00:07 fabiofdsantos

I think this action could help here: https://github.com/marketplace/actions/find-latest-tag.

rdwebdesign avatar Aug 07 '22 04:08 rdwebdesign

Check

  • #102

and

  • https://github.com/OskarStark/phpstan-ga/pull/58#issuecomment-1702263614

for more infos

OskarStark avatar Sep 01 '23 06:09 OskarStark

See for more info: https://github.com/OskarStark/phpstan-ga/pull/58#issuecomment-1702263614

OskarStark avatar Sep 06 '23 11:09 OskarStark