Tobias Nyholm

Results 325 comments of Tobias Nyholm

Make many smaller PRs, they are easier to review and agree upon. Start with just adding this support to the CatalogueManager end CatalogueMessage. Then you may make two more PRs,...

FYI. Using symfony-storage 0.3.0 will allow storing "approved".

Yeah. You've probably seen it already. But there is a `Metadata` class. If you use XLIFF then you will be able to save the metadata.

Thank you for the issue and PR. Could you elaborate on the use case for this?

That is what the ‘@desc’ annotation is for. Right?

This will extract a key "foobar" with the translation "English translation". ```php // @desc("English translation") $this->translator->trans('foobar') ``` -------- Current behavior is that this extracts a key "foobar" but with no...

Okey. I just checked the Symfony source and you are [correct](https://github.com/symfony/symfony/blob/4.1/src/Symfony/Bridge/Twig/Translation/TwigExtractor.php#L92). I do not think it is a good idea to add a translation that is same as the key...

It seams to be something strange when downloading from Loco. Check the `Loco::export` function. Is there any other `format` or `extension` that works? Maybe check the `index` parameter? https://localise.biz/api/docs/export/exportlocale

@dkozickis will the changes in https://github.com/php-translation/loco-adapter master fix your problem?

I like the feature. Isnt this very related to https://github.com/php-translation/symfony-bundle/pull/378? I mean, could one use `exportOptions` to support this feature?