[Xliff] Allow "approving" translations

[rvanlaak]

When translations are new, or when they have been edited lately, a workflow to approve them would help to ensure translation quality. The Xliff standard does support this out of the box, the bundle can help with that. Also see XliffExporter.

Scenario 1: new translation

• developer introduces a new translation key in a Twig view.
• translation bundle collects this key, and adds it to the xliff file with approved attribute set to no if the translation has a value.
• Web UI has specific styling / workflow for the non-approved translations, translator goes to UI to review those specific translations.
• The "approve translation" action sets approved to yes

Scenario 2: updating translation via edit in place or profiler

• translator uses edit in place or profiler to edit a translation
• POST action sets approved back to no
• same "approve" workflow via Web UI as in scenario 1

Scenario 3: updating translation web ui

• translator uses web ui to translate a key
• there are two "save" buttons, the normal "save" one (behaves as scenario 2), and a "save + approve" button
• translator saves and approves a translation key

Future enhancement could be to require a certain ROLE in order to approve a translation.

[Nyholm]

I like the ability of a support function. This is however only a xliff feature. But xliff is the standard =)

👍

To implement this we need to make changes to the CatalogueManager and the CatalougeMessage. If the translation is approved or not will go in the meta flag on the Common\Message so third party adapters may reach it

[rvanlaak]

If we can agree on the technical specs / changes, I'd like to help with the implementation right away 👍

One UI thing I mentioned already is that the web UI uses colors, but I think they are related to the completion percentage (?). These colors should change: gray or red is missing, green is approved, yellow is not approved yet.

[Nyholm]

Make many smaller PRs, they are easier to review and agree upon. Start with just adding this support to the CatalogueManager end CatalogueMessage.

Then you may make two more PRs, one for WebUI and one for EditInPlace.

[rvanlaak]

I first need to finish our migration to xliff, so I can probably start working on this in the beginning of next week.

[Nyholm]

FYI. Using symfony-storage 0.3.0 will allow storing "approved".

[rvanlaak]

@Nyholm any status update on the symfony-storage? Did it get any additional features that would be able to help us even better while implementing this?

[Nyholm]

Yeah. You've probably seen it already. But there is a Metadata class. If you use XLIFF then you will be able to save the metadata.