Miles Silberling-Cook
Miles Silberling-Cook
Great point, and interesting question! ## Generic Plugins I'm not familiar with rapier's plugin structure. In general, this will only let you depend on a single specific concrete plugin. However,...
That's definitely the intended approach if both plugins are generic. I will add some examples up above.
> Even tho I understand the proposed API I wonder if it is possible to make it match the Systems Dependency API This is the goal of the `PluginSet` api....
I'm in the middle of another much more thorough review of this, given that there seems to be a little contention in this thread. First off, I think we can...
Also we really should just do a second pass on all the documentation of the `cubic_splines` module. It's gets a little technical and sparse in several places. I would move...
I've just finished checking and the current form of `generate_matrix` is absolutely 100% correct. If you go through the derivation, that matrix actually encodes the quotient of the basis functions....
For reviewers who may be lurking, this is much closer but still not yet ready for merge. @IQuick143 identified a serious flaw with sampling and did a fantastic job fixing...
Yep, that's a fair call. I will submit some more tests to the upstream fork next week. I'm sure we can get this rock-solid for 0.14. Thanks Alice!
I think we need to think about the orphan rule before making a decision about the blanket trait impl. Left some thoughts on that comment thread (even thought it is...
I still consider this feature blocking on tests. We should not merge this until someone writes a more complete test suite for the nonlinear portion of NURBS. That can be...