Miles Silberling-Cook

Results 116 comments of Miles Silberling-Cook

A previous version of this feature (https://github.com/bevyengine/bevy/pull/8705) was closed due to incoherent stack traces. This issue was also brought up in discord. It seems similar to https://github.com/bevyengine/bevy/issues/8638 with logs from...

@alice-i-cecile requesting removal of the `M-Needs-Release-Note` label (added in pr description because we don't have a good place for it yet).

Alright, I added the most basic tests and examples in the world. There will be more to do there when handlers are hooked up. Ready for review.

> follow-up PR territory. Fair enough, agreed.

> Could you elaborate on what you mean by this? Mostly our api uses `X::foo() -> T` panics and `X::get_foo() -> Option` is non-panicing. This is also how the standard...

> Instead it would be nice if the scheduler could help with that, though I can't see a practical way right now. This sounds interesting. I do kind of feel...

Either way, I think we should still introduce a fallible version of `single`.

I think it makes sense to hold off on this until after the `DynamicClosure` split.

This does seem like the least-bad option. But I thought there was code in `bevy_transform` to specifically filter out ui elements from propagation. Could you check if that's still there...

Starting a review. From just the readme, this seems fantastic. Exactly what I was looking for in basically every way.