Miles Silberling-Cook

Results 116 comments of Miles Silberling-Cook

Alright, resolved feedback, improved docs, changed how things worked a bit to work with global observers, simplified things a bit, added an example. Should be ready for reviews. I intended...

Great, thank you! I prefer the bool as well, that's how I had it implemented before the first round of feedback. I'll get this cleaned up, benchmarked, and ready for...

Addressed review comments, added a benchmark, cleaned things up a bit. Preliminary profiling indicates this is a regression compared to the best case of `bevy_eventlisterner` but (a) its unlikely to...

> it's not clear to me that children should always be drawn above their ancestors I don't think we can assume this. We need to make it possible for children...

I'll have time to publish that work tomorrow.

Does this still need bubble-to-window? I have an open PR if so.

I think main always uses the -dev suffix. Should probably be bumped to 0.16 now.

All prs that touch the `Cargo.toml` are currently failing on that check-ban. It's flagging a newly unmaintained crate deep in our dependency tree (which incidentally happens to owned by a...

> there may be room to consider removing the panicking variants of certain functions That's in line with the third point Cart proposed in https://github.com/bevyengine/bevy/issues/14275#issuecomment-2223708314. He indicated then that it...

> This just makes the code more jarring compared to the rest of the Rust ecosystem In this I am trying to defer to my understanding of Cart's preferences. He...