Jordan Atwood

Results 370 comments of Jordan Atwood

[You're adding an infobox in your plugin which is never removed.](https://github.com/pwatts6060/runelite-plugins/blob/b1a74c9b8a0e211566f9ad17d1821fbf96841127/src/main/java/com/lmsnotifier/LMSPlugin.java#L181) Please ensure turning the plugin off will remove it.

[Do not use "example" as your config group.](https://github.com/WaylonJ/OSRS_ClickToMinimize/blob/80e1a91f0caa66d8929603e46556951c6e09dabb/src/main/java/com/clicktominimize/ClickToMinimizeConfig.java#L7) Code LGTM otherwise

You're [adding a nav button here](https://github.com/SomewhatUsefulSoftware/npc-animator/blob/98debd79289e46b6b507e915c5214c1afd5f190f/src/main/java/com/npcanimator/NPCAnimatorPlugin.java#L105) which is never removed, even on plugin shutdown, so disabling your plugin would not remove this button and toggling it would add multiple buttons....

I see your plugin doesn't currently have any config options, [but "pouch" isn't a sufficiently distinct config group](https://github.com/trs/runelite-hunter-pouch-overlay/blob/dcc682ba14bb869cdbc2ac7f80aacfb466aa0da3/src/main/java/com/pouch/HunterPouchConfig.java#L7); please either remove the config interface or change the config group to...

Can you [change your config group?](https://github.com/spektrum1/bank-black-list/blob/58716bb438eba86b40b7174840574f32ff557983/src/main/java/com/bankblacklist/Config.java#L31) "Block List" on its own is not as specific as "Bank Block List", or something of the like--I'd rather this be more specific than...

While [you are removing your overlays from being rendered on plugin shutdown](https://github.com/SimonFlapse/venom-timer/blob/289c2e7926382096a9b36f9455e25f828689f06b/src/main/java/com/simonflapse/osrs/venom/ui/OverlayOrchestrator.java#L54), they are not cleared from `activeOverlays`, so they are effectively leaked memory (and end up not being rendered)...

There isn't really anything that's possible in advance. At minimum, most items require the associated NpcID/ItemID entries to be added to runelite-api, or knowing the IDs of regions ingame. Those...

The remaining items haven't been worked on by anyone else in any capacity that I'm aware of, so we'd be happy to accept contributions that would take care of them.

I can't, issues can only be assigned to repo team members Edit: I've been informed this has changed; assigned you here.

Sure. We don't really have a system to "reserve" open issues/items, so go ahead