plugin-hub icon indicating copy to clipboard operation
plugin-hub copied to clipboard

add hunter pouch overlay plugin

Open trs opened this issue 10 months ago • 5 comments

This plugin adds an overlay to the hunter pouches showing the number of meat/furs inside.

icon

trs avatar Apr 21 '24 22:04 trs

New plugin hunter-pouch-overlay: https://github.com/trs/runelite-hunter-pouch-overlay/tree/dcc682ba14bb869cdbc2ac7f80aacfb466aa0da3

I've found a few issues I'd like to sort out before adding to the hub

trs avatar Apr 22 '24 04:04 trs

Just switch this PR to a draft until you've made the changes you feel necessary, and then update this PR to the new commit hash.

Felanbird avatar Apr 22 '24 04:04 Felanbird

Okay, after some fixes and testing this should be working good now. It previously wasn't taking into account if multiple actions were occurring during a single tick (like filling both meat and fur pouches quickly). Not sure if there's an easier way to accomplish this than the solution I came up with.

trs avatar Apr 24 '24 21:04 trs

I see your plugin doesn't currently have any config options, but "pouch" isn't a sufficiently distinct config group; please either remove the config interface or change the config group to be more unique. (either would help avoid possible conflicts in the future should you decide to add configs later on) Code LGTM otherwise

Nightfirecat avatar May 14 '24 01:05 Nightfirecat

Convert this off of draft when you've made the requested changes

LlemonDuck avatar Jul 09 '24 17:07 LlemonDuck

Closed for inactivity, you can reopen this if you would like to make the requested changes.

MESLewis avatar Oct 02 '24 15:10 MESLewis