plugin-hub
plugin-hub copied to clipboard
new bank-black-list plugin
This plugin allows you to blacklist certain items, causing a warning every time you leave them in your bank. Helpful for group ironmen forgetting to put their items back in the group storage.
New plugin bank-black-list: https://github.com/spektrum1/bank-black-list/tree/3a7903026531d62ddc502f25d0dd4ffed099a5e1
Don't use reflection
Don't use reflection
Fair. Is there a preferred way to retrieve an ItemID from a name string? Looking around the existing plugins I can't seem to manage to find an example
Why do you need an itemid? Why not get the item name and see if it matches the input?
ItemManager is probably what you want to use. It can get you the name from the id.
Why do you need an itemid? Why not get the item name and see if it matches the input?
ItemManager is probably what you want to use. It can get you the name from the id.
I was hoping to avoid doing a lookup for every bank item instead of just the items on the black list, but I made the change now. Thanks for the input
I think you are too worried about performance. Also, in the old version the reflective lookup was inside the double loop instead of in the config reading... so this new version is definitely faster XD.
I think you are too worried about performance. Also, in the old version the reflective lookup was inside the double loop instead of in the config reading... so this new version is definitely faster XD.
True woops. Talking about it might as well optimise a little more
Can you change your config group? "Block List" on its own is not as specific as "Bank Block List", or something of the like--I'd rather this be more specific than less to avoid possible conflicts down the line. Code LGTM otherwise
Done, thanks