plugin-hub
plugin-hub copied to clipboard
Create Venom Timer Plugin
Description
This plugin shows venom related information to help players identify envenomed actors.
Information available includes:
- Next venom splat hitting
- Next venom splat damange
- Total venom damage applied
- Expected time before target will die from venom damage
Screenshot
New plugin venom-timer
: https://github.com/SimonFlapse/venom-timer/tree/9f3ad66fa66262939d385a13f2a2ef86274e6236
Does this differ significantly from https://runelite.net/plugin-hub/show/poisoned-npcs? Could it be added to that plugin?
Does this differ significantly from https://runelite.net/plugin-hub/show/poisoned-npcs? Could it be added to that plugin?
I did consider it, but I found that it was very specific to the more advanced mechanics of poison.
While you are removing your overlays from being rendered on plugin shutdown, they are not cleared from activeOverlays
, so they are effectively leaked memory (and end up not being rendered) if you toggle the plugin off and back on. I recommend adding an activeOverlays.clear()
call in OverlayOrchestrator#shutDown()
.
While you are removing your overlays from being rendered on plugin shutdown, they are not cleared from
activeOverlays
, so they are effectively leaked memory (and end up not being rendered) if you toggle the plugin off and back on. I recommend adding anactiveOverlays.clear()
call inOverlayOrchestrator#shutDown()
.
Thanks for the review! I've applied your suggestion and updated the commit hash