plugin-hub icon indicating copy to clipboard operation
plugin-hub copied to clipboard

Create Venom Timer Plugin

Open SimonFlapse opened this issue 10 months ago • 5 comments

Description

This plugin shows venom related information to help players identify envenomed actors.

Information available includes:

  • Next venom splat hitting
  • Next venom splat damange
  • Total venom damage applied
  • Expected time before target will die from venom damage

Screenshot

Screenshot 2024-04-13 210219

SimonFlapse avatar Apr 13 '24 19:04 SimonFlapse

New plugin venom-timer: https://github.com/SimonFlapse/venom-timer/tree/9f3ad66fa66262939d385a13f2a2ef86274e6236

Does this differ significantly from https://runelite.net/plugin-hub/show/poisoned-npcs? Could it be added to that plugin?

YvesW avatar Apr 14 '24 02:04 YvesW

Does this differ significantly from https://runelite.net/plugin-hub/show/poisoned-npcs? Could it be added to that plugin?

I did consider it, but I found that it was very specific to the more advanced mechanics of poison.

SimonFlapse avatar Apr 14 '24 05:04 SimonFlapse

While you are removing your overlays from being rendered on plugin shutdown, they are not cleared from activeOverlays, so they are effectively leaked memory (and end up not being rendered) if you toggle the plugin off and back on. I recommend adding an activeOverlays.clear() call in OverlayOrchestrator#shutDown().

Nightfirecat avatar May 13 '24 04:05 Nightfirecat

While you are removing your overlays from being rendered on plugin shutdown, they are not cleared from activeOverlays, so they are effectively leaked memory (and end up not being rendered) if you toggle the plugin off and back on. I recommend adding an activeOverlays.clear() call in OverlayOrchestrator#shutDown().

Thanks for the review! I've applied your suggestion and updated the commit hash

SimonFlapse avatar May 14 '24 14:05 SimonFlapse