Nicolas Giard

Results 173 comments of Nicolas Giard

@skmbr See https://github.com/davestewart/vuex-pathify/issues/130#issuecomment-926991066

I also started to use Vue 3 for a new project and found out that vuex-pathify doesn't work. The main issues seem to be: - dependency on `vue-class-component`, which doesn't...

I made a [fork](https://github.com/Requarks/vuex-pathify) of the project without the vue-class-component dependency. This fixes all the warnings when using Vue 3. Also replaced rollup with esbuild for the actual build as...

@iKnowMagic I added back the typings in 2.0.2 while removing the vue-class-components reference from them. However I'm not using Typescript so I have no idea if more changes are needed....

@davestewart Vue 3 works great with the new [Vuex 4](https://next.vuex.vuejs.org/) and is still the way the go for state management.

Yarn 3 works perfectly fine as long as you set `nodeLinker: node-modules` in your `.yarnrc.yml` Proper pnp mode support would be great in the future though...

You should also save the xml output to disk to avoid querying the DB on every page hit. Something like... ```js const cachePath = path.resolve(WIKI.ROOTPATH, WIKI.config.dataPath, `cache/sitemap.xml`) try { const...

The cache should indeed be cleared when making changes to pages. Add a line to: https://github.com/requarks/wiki/blob/main/server/models/pages.js#L1112 to remove the `sitemap.xml` file. This method gets called when a page is modified...

Your PR completely removes translation support. You should instead add a fallback value: `this.$t('common:sidebar.root', '/ (root)')`

Deferred to next major release as this can potentially cause issues with existing installations / reinstall with scripts that would need to be updated.