Nicolas Giard

Results 173 comments of Nicolas Giard

The reason the code injection is not included in editor/admin pages is because there's a risk of completely bricking the page if user code does something unexpected. Then you have...

> @NGPixel What will be the release date of version 3.0? See https://docs.requarks.io/releases

There are several issues with your PR: - Changes are to entire files instead of just the specific lines where strings need to be replaced. - Many strings don't exist...

Your PR has many issues I listed earlier and your responses to them don't make sense. Formatting and key naming are wrong. It's not a matter of whether it works...

@khedrub Please read https://docs.requarks.io/en/releases/about This feature will be included in the 3.0 release.

It will be implemented in 3.0 update, which will include proper theming handling. I didn't want to merge something, including API changes, that would change in the following version.

I would consider accepting this PR for 2.x as the next version still require more time. I would however want some UI changes as to not rely on 10 radio...

an auto-install will not be added in 2.x, as this could introduce new issues and would require some extensive documentation as to what it does and what must be provided....