wiki
wiki copied to clipboard
Fix sidebar root title by not overiding it when translation isn't yet available
Fixes: https://github.com/requarks/wiki/discussions/4888
Before:
After:
I'm not sure why but the root parent's title is being overriden with a translatable title. But this happens in the mount handler when the translation isn't yet available, causing it to fallback to the text "sidebar.root".
Your PR completely removes translation support. You should instead add a fallback value:
this.$t('common:sidebar.root', '/ (root)')
I'll have another look at making the title adapt to translation updates, but I don't think what you're suggesting will much.
In the data
the currentParent
already gets that '/ (root)'
as a default. It might add a fallback for when fetchBrowseItems
is called before mounted
, but I've seen that during the mount event the translation isn't retrieved yet.
What do you think about this approach?
Could you have another look?
Looking for this as well :)