Gino Valente

Results 207 comments of Gino Valente

> Previously discussed in #92 and #4153. To make life easier for reviewers, how does this compare to this proposals? I actually hadn't seen #92, so thanks for pointing that...

I updated the code and the PR description to follow @Metadorius' suggestion! It now uses `{type_name: data}` in place of `{type: type_name, value: data}`.

Is there a need for the enum? Couldn't we just pass around the raw `u32` wrapped in a newtype?

> Maybe, but i'm very new to rust, like, i'm two weeks into it for now No worries, glad you're contributing already. It's a great way to learn! 😄 I’d...

> 2. Add a new feature called tile atlas builder that brings in bevy_tile_atlas as a dependency? You mean re-export it like: ```rust #[cfg(feature = "tile_atlas")] pub use bevy_tile_atlas as...

Check out the methods defined on `Style` here: https://github.com/StarArawn/kayak_ui/blob/54c67ecd252ee441eb2bb2fdd56b2e5a9ee7f391/kayak_core/src/styles/mod.rs#L150-L188 It sounds like you want to use `apply` (or `with_style` for builder-like syntax). If a style has any `StyleProp::Unset` values, these...

Interesting... Would you be willing to draft up a PR so we can take a look at it in real examples? It might be a nice QoL feature. Any thoughts...

> Ideally we should likely use an array texture here. Not something I’m too familiar with. Should we make a separate issue for that?

> Yeah! Is the warping an existing issue? I haven't tested it, but I’m guessing it is. I can run a test later today to verify that it existed before...

Hm. Did you set your font default in the `FontMapping` resource? Edit: Didn't see Star's comment. Disregard this one haha.