Gino Valente

Results 207 comments of Gino Valente

> However this is controversial as its starting to encroach on "prefab space" and the concerns outlined in the "Components as Bundles" conversation: [#2974 (comment)](https://github.com/bevyengine/bevy/issues/2974#issuecomment-1029473497), where we agreed that Bundles...

Sounds like this is due to the proc macro not specifying the fully qualified path to `Result` (i.e. `::core::result::Result`). This seems like it would be a trivial fix and should...

> I would like to solve this issue. But being new to Rust and this codebase, I wanted to clarify a few things: Awesome! Glad to have you on board!...

> > Users can then choose to opt-out if needed using the #[from_reflect(auto_derive = false)] attribute. > > > > Wouldn't it make more sense to have this as `#[reflect(auto_derive_from_reflect...

> I've been looking at this PR and #6245 and been reading the [Related RFC](https://github.com/MrGVSV/rfcs/blob/main/rfcs/59-from_reflect_ergonomics.md) and I'm not a fan of automatically deriving `FromReflect`. While I agree with you that...

> Have you considered gating this behind a feature? i.e. only auto derive `FromReflect` if `feature = "xyz"`. Hm, that might be a fair compromise 🤔 I mean, this PR...

Yeah I think if we went ahead and put this behind a feature, it'd be best to make it a default one. But I'd like to hear other people's thoughts....

> If it is behind a feature, disabling the feature is likely to prevent that project from making use of the future Bevy editor. True. Even beyond scenes, the future...

## Update June 3, 2023 ### What happened to the RFC? After some thought, I'm closing out the [RFC](https://github.com/bevyengine/rfcs/pull/59) in favor of this PR. The RFC was meant to gain...

> @soqb did bring up some good points, but I think those can be addressed in followups. Yeah I was meaning to get to those but just got busy. Out...