bevy_ecs_tilemap icon indicating copy to clipboard operation
bevy_ecs_tilemap copied to clipboard

Replace the newly added `TileAtlasBuilder` with a dependency

Open MrGVSV opened this issue 3 years ago • 2 comments

The TileAtlasBuilder that was recently added (by my mistake 😅) could be replaced with a dependency on bevy_tile_atlas.

The addition is actually an outdated version of that crate (I wrote it in my fork of this repo first before turning it into its own crate for general Bevy usage). I think it would be best to re-export that crate internally if we want to continue to use it.

MrGVSV avatar Jan 01 '22 23:01 MrGVSV

I've been meaning to get back to you about this. Would it be okay to do the following?

  1. Remove TileAtlasBuilder
  2. Add a new feature called tile atlas builder that brings in bevy_tile_atlas as a dependency?

StarArawn avatar Jan 22 '22 00:01 StarArawn

  1. Add a new feature called tile atlas builder that brings in bevy_tile_atlas as a dependency?

You mean re-export it like:

#[cfg(feature = "tile_atlas")]
pub use bevy_tile_atlas as tile_atlas;

or:

#[cfg(feature = "tile_atlas")]
pub use bevy_tile_atlas::*;

or something else?


I'm fine with removing the file and re-exporting if you are (we also don't need to include it if you don't want haha).

MrGVSV avatar Jan 22 '22 02:01 MrGVSV