Gino Valente

Results 207 comments of Gino Valente

Yeah I prefer returning a `Result` from `Reflect::apply` as well.

This sort of came up on Discord recently, albeit in regards to my work on diffing. If we end up returning a Result, we have to make sure that it's...

> I like the idea but can't say I'm a fan of this name, "ReflectFromReflect" doesn't seem very intuitive to me. Maybe ConvertFromReflect, CastFromReflect, ValueFromReflect, TypeFromReflect? Yeah, I don't _love_...

> * I'm getting pretty poor performance on my laptop. Even though I only have integrated graphics, click events have a pretty big delay, even on the `game_menu` example. I'm...

> I like this change. But I would suggest to keep the original `map_entities` and rename it into `map_all_entities` and call your new method `map_entities`. It will allow to avoid...

> I'm basically in agreement with that. I think we should instead exclude these components and entities from the default serialization. Should be possible once we merge #6793

Hm, I'm debating on whether or not I should rename `Function` to `Func`. If we ever want to add a `Function` trait, then it might be good to do it...

I added the changes suggested by @BD103. Unfortunately, it seems adding HTML in the markdown is causing a [CI failure](https://github.com/bevyengine/bevy/actions/runs/7880279923/job/21502078060?pr=11750)?

> As a (potential) counterargument: a Showcase section has a high risk of being redundant with the Solution section. I've tended to write "release note style showcases" of my features...

> Any chance we could do something like this for some type safety / name clashing protection? > > ```rust > #[derive(Reflect)] > struct Slider { > #[reflect(InspectRange { min...