Moshe Atlow

Results 213 comments of Moshe Atlow

> Also, there are some thoughts regarding concurrency that seem like you missed can you elaborate?

> @MoLow once this lands, do you think it will be feasible to make --test-only only necessary when running multiple processes? It seems like it to me, but I haven't...

do we have a benchmark test for `--test-name-pattern`? the changes looks ok but I wonder what are the performance implications

> @MoLow why do you consider it a major (breaking) change? 🤔 it rather won't affect current usages of `--test-name-pattern` but adds support for matching single test by prefixing with...

sounds like a legit feature. @nodejs/test_runner WDYT?

> It would be interesting to test that, either by spawning a child process to start mocha, or by not spawning a child process to start node:test implementation. that can...

I think filtering tests and running `only` test is currently broken in node:test. we have a few issues discussing that https://github.com/nodejs/node/pull/48932#:~:text=Fixes%3A-,%2347945,-this%20PR%20is

> @nodejs/test_runner @MoLow I think in any case the callback test failing shouldn't interfere with any of the other tests. > > Re: the second example - The "fail the...