Moshe Atlow

Results 213 comments of Moshe Atlow

> As such, I would expect no transforms. This should be done by the users before passing any value to be compared. That way we are also aligned with our...

> It has no option _where_ to read from the snapshot, only the actual snapshot content (e.g., an object or a string). That way reading and writing are up to...

> We can start with `assert.snapshot(input)` and decide upon further details later. That will prevent even basic usecases such as specifying a location for the snapshot file. If options are...

@BridgeAR @benjamingr @cjihrig @mscdex @juliangruber I implemented the minimal implemetation discussed above - can you please take a look?

> I'd still love an explanation (per [#44095 (comment)](https://github.com/nodejs/node/pull/44095#discussion_r937425378)) for why having the snapshot name be implicit/optional is "simpler" than requiring an explicit one for this first iteration. Sure, lets...

ping @benjamingr this needs a fresh approval

probably for starters, as @benjamingr support `/.tsx?$/` as well, eventually allow configuration of custom file filtering

Perhaps we should implement a solution for https://github.com/nodejs/node/issues/43895 (that will allow passing a custom function to filter files) I am willing to implement some `--test-config` flag if there is consensus...

> Maybe a better solution would be to have an option for the loader to have an option to tell which file patten it supports for tests? why will it...

I might not fully understand how loaders work, so correct me in case I am wrong - a loader does not expose what file extensions it supports, So there is...