Moshe Atlow

Results 175 comments of Moshe Atlow

> Yeah, it won't actually "separate" them but the events will come in order due to this [line](https://github.com/nodejs/node/blob/main/lib/internal/test_runner/runner.js?rgh-link-date=2023-07-01T06%3A45%3A21Z#L187), right? yeah, it will come in order.

this PR seems to be missing a test. @mertcanaltin can you please add on in a follow-up pr?

we should probably just add a `withFileTypes` option like `fs.readDir` has

this will only work as expected in case of no parallelism/concurrency. otherwise, there is just the option for a best effort where as soon as the orchestrator knows of a...

I Will try taking a look next week. might be related to the changes in https://github.com/nodejs/node/pull/52358

> Can you please add a unit test? there are existing tests in place that need to be updated. see https://github.com/nodejs/node/pull/52655#pullrequestreview-2018141409

@mihir254 I am not sure what is wrong with running linter by you, but if you are having trouble, I can fix lint issues and push to this branch

> It does not expect to see the failing tests (test/parallel/test-runner-reporters.js line 84). Any directions on that? you should probably copy what was done in the spec reporter and adjust

@mihir254 please squash/remove the merge commit. if you need help with that or you want me to perform that, LMK