Moshe Atlow

Results 175 comments of Moshe Atlow

> This will enable interop with TypeScript, right? i.e. Yes!

@isaacs I have changed the glob algorithm to something much closer to what `node-glob` does. PTAL I am open to adding `node-glob` as a dependency in the long term, but...

@nodejs/test_runner please review

> Would replacing the implementation be a breaking change? If so, do we need to mark this as experimental and/or add a warning? no, it should be compatible - the...

> What makes it semver-major? there are some cases (https://github.com/nodejs/node/pull/47653#discussion_r1173663388) where filenames are valid glob patterns. also - prior to this pr running `node --test some/directory` would run all test...

> I know this may be a lot to ask, but it would be really awesome if this could be non-breaking, so it can be released in full with Node.js...

> Oh, one other question, what's the goal of this PR? Should I be reviewing this in the context of "general purpose glob impl that will be exposed to users...

> Would you be able to make one or more commits that are not semver-major, so the introduction of the globbing code can be backported for future usage? I know...

@nodejs/test_runner I think this is ready, can you review?

SGTM, I wonder if this isnt just another cache layer but if the implementation isn't too complex it can be ok