Moshe Atlow

Results 176 comments of Moshe Atlow

> I think probably just allowing an RE or glob of test files then as an argument for `--test` ? core doesn't currently support glob and regex can be hard...

> Currently `--test` doesn't take any value right? So we could introduce a semver-minor change saying that now `--test` can take an optional string value that will be interpreted as...

@aduh95 see https://github.com/nodejs/node/blob/2fe4e9473fb50630326754886dee1d301a1a661e/test/parallel/test-runner-cli.js#L11 https://github.com/nodejs/node/blob/2fe4e9473fb50630326754886dee1d301a1a661e/test/parallel/test-runner-cli.js#L23 https://github.com/nodejs/node/blob/2fe4e9473fb50630326754886dee1d301a1a661e/test/parallel/test-runner-cli.js#L55 https://github.com/nodejs/node/blob/2fe4e9473fb50630326754886dee1d301a1a661e/test/parallel/test-runner-exit-code.js#L47 etc

assuming that adding glob to core has a bigger scope than a small fix to the test runner, what will be the process of adding this to core? which teams...

I see that this was already raised here https://github.com/nodejs/node/issues/40731#issuecomment-1054519184 and https://github.com/nodejs/node/issues/40954#issuecomment-1037973165 with no real objections @isaacs can you update where this stands? there is now a real use case for...

> I’m growing concerned by the number of dependencies that are becoming part of core as part of shipping our own test runner. I realize this might be a concern,...

> This is already possible without work from core, right? Possible yes. not great DX if you ask me :/

> Or you could use an npm package are you saying the test runner `--test` flag is not useful and only the `node:test` module is?

I am +1 on `import { runTests } from 'node:test'` However, `import { config } from 'node:test'` doesn't sound correct: What happens if two different configurations are set in two...

> I assume `config` would only apply when `--test` is passed, so it would only have an effect if it's pre-imported (using `--require` or `--import`). that is pretty much what...