Mingun

Results 397 comments of Mingun

AS time goes it becomes more and more difficult to monitor the relevance of this PR. If you are not ready to take it all at once, then you can...

Just note, that scala-js up to 1.10 has a security vulnerability and it is recommended to upgrade ASAP: https://www.scala-js.org/news/2022/04/04/announcing-scalajs-1.10.0/

@GreyCat, @generalmimon, another easy-to-review PR. Can lo please look?

Another round of black magic... cast @GreyCat, cast @generalmimon, cast anyone with merge rights...

[#787](https://github.com/kaitai-io/kaitai_struct/issues/787) is related documenting issue

@generalmimon , I see that you've started to merge some PRs and close issues. Could you look at my PRs? This one is a good candidate to start. List of...

Hey! Let's finish this (and [other PRs](https://github.com/pulls?q=is%3Aopen+is%3Apr+author%3AMingun+user%3Akaitai-io+archived%3Afalse)) before end of year! 😃 @GreyCat, @generalmimon, @dgelessus

I've found that probably changing `factory` to `compiler` is wrong. According my analysis, current `master` does the following: - `root.KaitaiStructCompiler` is a _kaitai struct compiler constructor function_, should be used...

> But I'm reluctant to make such a daring BC break, because [`kaitai-struct-compiler` at _npm_](https://www.npmjs.com/package/kaitai-struct-compiler) is used quite a lot in the wild (as you can see from the download...