Micha Reiser

Results 1092 comments of Micha Reiser

ty does support publish diagnostics already (on `didChange`) but it only publishes diagnostics for the changed file. This is not sufficient if you have `lib.py` and `main.py` where you make...

Oh nice, find. I should have a fix any minute :)

> As far as I can read in the LSP spec, there is the 'relatedDocumentSupport' client sub-capability, but no server that I know consults it or does anything useful with...

> I think brute-forcing this from the client is pretty inefficient. clangd seems to maintain this, for example. It publishes diagnostics for affected files and affected files only (though only...

I would expect `Variable` for `_var`, which is also what I'd expect us to show if I hover it (it tells me it's a variable of type `Class`). This is...

> This would avoid needing to use the use-def map directly (which seems trickier?). You might also be able to use some of the go-to-definition machinery for this

> I don't understand how this can be possible, since explicit_bases is a Salsa query: surely after it's been called once, the result should be cached and it should return...

> It will only return a result after the cycle has converged, I think? `is_protocol` might participate in the cycle and it can then see the provisional value (not converged...

> OK, thanks. In that case this .expect() call seems definitely unsafe, as we can't rely on is_protocol returning a consistent thing for one class. I have to read the...