Micha Reiser

Results 1092 comments of Micha Reiser

> Notably I think we should skip scripts on workspace diagnostics by default. (...which now that I've said that, that will be annoying if your scripts import monorepo members and...

Thanks for the kind words. We're aware that many issues are currently blocked on rule categorization and it's our plan to resolve rule categorization in the coming months, to unblock...

Thanks for the detailed write up. I can understand that nested comprehensions can get hard to read. > Would it be possible to have an opt-in feature to always preserve...

Rustfmt's default is to use lower limits for these inline expressions. This seems reasonable and is probably not too hard to implement https://rust-lang.github.io/rustfmt/?version=v1.8.0&search=#use_small_heuristics Finding the right percentages could be challenging

I don't think we made a decision. I only posted it as reference and expressed that I'm open to it because it's relatively simple to implement. I also never found...

Let's keep this discussion focused on how we can improve the comprehension formatting with how the formatter works today. Ideally, that shouldn't even matter and we can focus on when...

Thanks for the analysis. > I think this demonstrates substantial community adoption of the pattern and warrants being supported by the ruff formatter, to the developer's discretion. I don't agree...

Sorry no. We've all been busy with other features/formatter styles

Fixing this will require changes in the parser. The issue is that we, for some reason, omit the entire `dataclass` from the parsed result instead of recovering after the `@`

We introduced the `analysis.respect-type-ignore-comments` setting, which should put us in a position to enable this rule by default. However, I think we should wait until we fixed the instability (involving...