Micha Reiser
Micha Reiser
Not saying we shouldn't do this, but this setting might feel weird if we decide to integrate isort into the formatter because it sets a new precedence that the formatter...
I like convention over configuration but also wouldn't mind it being an option. The performance is probably comparable between the two because one requires resolving the settings first and the...
We could establish the convention. That's how conventions happen :) It just feels slightly easier if all you have to do is: Create a `__builtins__.pyi`, done compared to create a...
I think one issue with the current implementation is that `resolve_module` resolves `__builtins__.py` from any search path, including third-party ones. We should definitely change that.
> But at that point, you've already said that the user will need some kind of explicit configuration to opt into this behaviour (they need to specify a certain directory...
IMO, defaulting to `__builtins__.pyi` seems fine and we could consider an option that allows you to rename the module name (it would be a module name and not a path)....
I'm not very familiar with how gitlab works but did you follow the [pre-commit GitLab setup instructions](https://pre-commit.com/#gitlab-ci-example)? That it's downloading files is expected but the caching should help reduce the...
Can you share an example of how you're using the pre-commit in your GitLab CI pipeline?
Hmm okay, I don't think I understand what you're looking for. You said that you want to run pre-commit on GitLab but it seems you're not? Did you try pre-commit's...
This overall looks correct and this seems like an issue with your git client not being able to authenticate against your gitlab repository. I'm not sure how I can help...