Micha Reiser
Micha Reiser
Thanks for the kind words. Can you tell us a bit more about your setup? * Do you use a single or multiple virtual environments? * Is the main motivation...
> some services may have overlapping module names (e.g., both service-a and service-b define their own constants.py / models.py), so being able to control extraPaths per service lets us isolate...
> I don't think this would produce consistent or accurate results when typechecking. If each package requires separate search-path settings, I think the only way to accurately type-check them would...
I agree that it can lead to inconsistencies. I think the main challenge here is how to enable this in the LSP and the CLI while giving a consistent experience....
This definetely needs some design ;) What I find important to point out is that we do want per-package isolation per-default when it comes to third party imports for users...
For anyone working on this, VS Code has a debugging tool to inspect the semantic token at any given position, see https://code.visualstudio.com/api/language-extensions/syntax-highlight-guide#scope-inspector Relevant for `float`, a type var `U` gets...
> int and str are correctly identified as SemanticTokenType::Class, while float falls back to SemanticTokenType::Variable. When classes/types have a special color (common in editor themes, but currently not on ty's...
@Gankra probably not. I suggest taking a look at the classification to understand why we classify the names the way we do, see this comment for how to do that...
Can you say more about what the benefit is of doing this as part of semantic tokens instead of leaving it to syntatic tokens (which most editors provide anyway)
The main reason not to do it in the LSP is that it makes the response larger, and most editors already run syntax highlighting, so it's just unnecessary duplication. I'm...