Micha Reiser
Micha Reiser
@carljm is this still something you plan to look into next week?
The most "trivial" implementation here would be to filter out syntax errors on the LSP side.
I think adding this as a configuration option (or having a drop down with `LSP`, `Diagnostics only`, and `Full`) makes sense. An alternative is to allow users to easily deselect...
> +1 for this. I'm having @carlesoctav's setup too: pyright (no diag) + ruff. This feature feels mandatory and obvious, especially since many of us already use ruff. Note that...
> What makes ty an exception to this rule? It works fundamentally differently from Ruff because it supports multifile analysis. Integrating ty (or ruff into ty) is a big lift....
As with other string related fixes, we could consider disabling the fix if the string contains nested quotes. Ideally we would be somewhat clever about it to only disable it...
> I'm not sure what do you mean here because we do fix this correctly by flipping the quotes but we don't consider nested quotes inside another existing string literal...
Curious to see the memory report. I suspect that this will regress memory usage quiet significantely and may require waiting for within-revision LRU support in salsa
Can you say more about what the benefits are for ruff? We don't need a "can parse all pragma comments" parser, we only need to parse the few comments supported...
@JelleZijlstra what do you think of adding this to Black/Ruff's formatter in addition or instead of a lint rule?