BuShe Pie

Results 11 comments of BuShe Pie

> > Could we re-request CI again? > > > > It is under security embargo. Anything should I do for that?

> All other files use the extension `.yml` as far as I can tell. I'd suggest renaming to `build-androi.yml` for consistency. You're right, it's a mistake.

> - Is there any way to try and run it before merging? > > - Is it going to block commit queue when it fails? 1. We are waiting...

@tniessen @targos `continue-on-error` has been used already(dea50f6f4e986a907f2353028eed77987876decf).

> I'm still sceptical about having feedback on all pull requests for a very experimental target. > > A new actions run will use a worker from the pool and...

Maybe label is a better idea? We label PRs when if it fit to run Android build test.

> path based Action? Would allow a smaller number of PRs that have it as a check as a way to warm up to having it on all PRs. I...

> Wouldn't it be better to keep the patch support in `android_configure.py` and only remove the actual patch? We might need to apply another patch in the future, no? I...