node icon indicating copy to clipboard operation
node copied to clipboard

build: remove `librt` library dependency for Android compatibility

Open MeowShe opened this issue 1 year ago • 10 comments

On Android, unlike Linux, there are no separate libpthread or librt libraries. That functionality is included directly in libc, which does not need to be explicitly linked against. (Native APIs | Android NDK)

Remove librt library dependency when building Node.js for Android, as it does not exist on Android.

Related to PR #51646, as part of a series of build fixes for Android.

MeowShe avatar Feb 01 '24 11:02 MeowShe

Review requested:

  • [ ] @nodejs/gyp
  • [ ] @nodejs/v8-update

nodejs-github-bot avatar Feb 01 '24 11:02 nodejs-github-bot

CI: https://ci.nodejs.org/job/node-test-pull-request/57038/

nodejs-github-bot avatar Feb 03 '24 15:02 nodejs-github-bot

V8 CI: https://ci.nodejs.org/job/node-test-commit-v8-linux/nodes=benchmark-ubuntu2204-intel-64,v8test=v8test/5798/

nodejs-github-bot avatar Feb 03 '24 15:02 nodejs-github-bot

V8 CI: https://ci.nodejs.org/job/node-test-commit-v8-linux/nodes=rhel8-s390x,v8test=v8test/5798/

nodejs-github-bot avatar Feb 03 '24 15:02 nodejs-github-bot

V8 CI: https://ci.nodejs.org/job/node-test-commit-v8-linux/nodes=rhel8-ppc64le,v8test=v8test/5798/

nodejs-github-bot avatar Feb 03 '24 16:02 nodejs-github-bot

Could we re-request CI again?

MeowShe avatar Feb 05 '24 04:02 MeowShe

Could we re-request CI again?

It is under security embargo.

lpinca avatar Feb 12 '24 19:02 lpinca

Could we re-request CI again?

It is under security embargo.

Anything should I do for that?

MeowShe avatar Feb 14 '24 11:02 MeowShe

No, thank you.

lpinca avatar Feb 14 '24 11:02 lpinca

CI: https://ci.nodejs.org/job/node-test-pull-request/57092/

nodejs-github-bot avatar Feb 15 '24 11:02 nodejs-github-bot

CI: https://ci.nodejs.org/job/node-test-pull-request/57391/

nodejs-github-bot avatar Feb 24 '24 19:02 nodejs-github-bot

Landed in 56ced192a1dee73188fa33b113162ebfc4ea1fd6

nodejs-github-bot avatar Feb 25 '24 06:02 nodejs-github-bot