node
node copied to clipboard
build: remove `librt` library dependency for Android compatibility
On Android, unlike Linux, there are no separate libpthread or librt libraries. That functionality is included directly in libc, which does not need to be explicitly linked against. (Native APIs | Android NDK)
Remove librt
library dependency when building Node.js for Android, as it does not exist on Android.
Related to PR #51646, as part of a series of build fixes for Android.
Review requested:
- [ ] @nodejs/gyp
- [ ] @nodejs/v8-update
CI: https://ci.nodejs.org/job/node-test-pull-request/57038/
V8 CI: https://ci.nodejs.org/job/node-test-commit-v8-linux/nodes=benchmark-ubuntu2204-intel-64,v8test=v8test/5798/
V8 CI: https://ci.nodejs.org/job/node-test-commit-v8-linux/nodes=rhel8-s390x,v8test=v8test/5798/
V8 CI: https://ci.nodejs.org/job/node-test-commit-v8-linux/nodes=rhel8-ppc64le,v8test=v8test/5798/
Could we re-request CI again?
Could we re-request CI again?
It is under security embargo.
Could we re-request CI again?
It is under security embargo.
Anything should I do for that?
No, thank you.
CI: https://ci.nodejs.org/job/node-test-pull-request/57092/
CI: https://ci.nodejs.org/job/node-test-pull-request/57391/
Landed in 56ced192a1dee73188fa33b113162ebfc4ea1fd6