node
node copied to clipboard
build: remove `patch` for Android build
Patch to src/trap-handler/trap-handler.h
is no longer needed now in Android building.
Tested on Docker with image ubuntu:latest
with nodejs/node@eca4b1a403959d5b83fb5a9adaae8f4c3580eea2 (HEAD), android-ndk-r26b-linux
.
Related to PR #51632, as part of a series of build fixes for Android.
CC @richardlau
Wouldn't it be better to keep the patch support in android_configure.py
and only remove the actual patch? We might need to apply another patch in the future, no?
Wouldn't it be better to keep the patch support in
android_configure.py
and only remove the actual patch? We might need to apply another patch in the future, no?
I understand your point, however, the patch was initially intended as a compromise, and all issues that arise should be addressed at their source, rather than being temporarily mitigated through patches.
But again, I think it's going to take some time to transition, so let's keep the patch for now, and thank you for your input.