Matan Borenkraout comments

Results 228 comments of


                                            Matan Borenkraout

Re-export computeAccessibleName and computeAccessibleDescription for UMD uses

@eps1lon I don't mind doing this but I'd love to hear your take on it.

can't find element by role `code`

Hi @chiptus! Thanks for taking the time to open this one :) Since the issue you're experiencing here is related to implicit roles, `aria-query` is indeed the package we're using...

can't find element by role `code`

Thanks @EmeraldWeb! I see that the spec was updated. I've opened an issue for `aria-query` regarding this :)

can't find element by role `code`

@CalebJamesStevens, there's no need to bump this issue, we're waiting for `aria-query` to release a new version, once they will release it, we will upgrade our dependency. @eps1lon do you...

can't find element by role `code`

Thanks @jlp-craigmorten! @all-contributors please add @jlp-craigmorten for question

`computeAccessibleName` won't compute combobox name from self referencing aria-labelledby attr

AFAIU from the [spec](https://www.w3.org/TR/wai-aria-1.2/#combobox), that's because `role="combobox"` should only be on an `input` element and not on a `div` element. Having said that, the `combobox` role's spec is extremely convoluted.

`computeAccessibleName` won't compute combobox name from self referencing aria-labelledby attr

I understand. I know that @eps1lon is also involved with mui so let's wait for his call on this one :)

not.toBeChecked is giving false even when checked prop is not in the element1

Hi @jackvik. It doesn't look like this bug report has enough info for one of us to reproduce it. Please provide a CodeSandbox ([https://react.new/](https://react.new/)), or a link to a repository...

Rethink testing strategy

@ph-fritsche Is there something still open here? :) Need a hand?

Rethink testing strategy

@ph-fritsche It looks like the `validate` step there succeeded and the logs aren't retained anymore because the run is probably too old. I can't find a way to re-run that...