Matthew Peveler

Results 298 comments of Matthew Peveler

Should there be a new label created named "Revision Needed" or something for the case where there's a comment by @tldr-bot or the PR request changes?

Ah, I missed the "waiting" label, yeah, that works.

Not sure what the `0.next-assoc` branch was in phinx? Should that be recreated?

@dereuromark what is the status of this PR? Anything I can do to help this along to continue on releasing phinx 0.13?

I suspect there are more test failures, but the merge conflicts in this PR need to be resolved first so that the test suite runs again? Also not sure if...

I tried, and it did not resolve the problem. I think the problem lies with: https://github.com/apollographql/apollo-cache-persist/blob/eded0ff380cd4b5e9d33f93ae8cb48897a791d8d/src/types/index.ts#L27 where TS is not smart enough to see that I'm passing it `false` in...

Having a thin client in node would be absolutely awesome and simplify my life tremendously as having to include the instant client stuff with our electron app easily outweighs the...

I would recommend using https://hub.docker.com/r/yandex/clickhouse-server/ for a docker image. It's the official image and includes also easy way to connect with a native client (that also runs under docker) for...

I tested this PR and it will also fix the issue I just reported in #2777. :+1:

Not sure why the Windows tests are failing on a date test. That should be unrelated to this PR?