migrations
migrations copied to clipboard
cakephp
Fix up Migrations for Phinx 0.13 integration.
Together with https://github.com/cakephp/phinx/pull/2033 this enables new Phinx major together with CakePHP 4.3+.
PHPStan passes, but Psalm has a few issues still it seems, even though they should be gone (I tried to clear cache, didn't help)
TODO: Also JSON part seems broken/problematic as per return type of parent.
I might need a bit help for the remaining errors.
1) Migrations\Test\TestCase\Command\BakeMigrationDiffCommandTest::testEmptyHistoryNoMigrations
Symfony\Component\Console\Exception\InvalidArgumentException: The "configuration" option does not exist.
/home/runner/work/migrations/migrations/vendor/symfony/console/Input/Input.php:158
/home/runner/work/migrations/migrations/vendor/robmorgan/phinx/src/Phinx/Console/Command/AbstractCommand.php:239
/home/runner/work/migrations/migrations/vendor/robmorgan/phinx/src/Phinx/Console/Command/AbstractCommand.php:281
/home/runner/work/migrations/migrations/vendor/robmorgan/phinx/src/Phinx/Console/Command/AbstractCommand.php:117
/home/runner/work/migrations/migrations/src/Command/Phinx/CommandTrait.php:66
/home/runner/work/migrations/migrations/src/Command/Phinx/MarkMigrated.php:112
Any idea why this would be happening now?
Not sure what the 0.next-assoc branch was in phinx? Should that be recreated?
Yeah, wrong branch as well, I guess It should probably to towards 3.x now.
The 3.x release was bad, without those changes :/
@dereuromark what is the status of this PR? Anything I can do to help this along to continue on releasing phinx 0.13?
Do we have any blockers from Migrations side? I remember there were some tests failing that we didnt know how to handle.
I suspect there are more test failures, but the merge conflicts in this PR need to be resolved first so that the test suite runs again? Also not sure if the test failures are things that need me to look at from the phinx side, or if they're more migrations specific stuff.