Matthew Peveler

Results 298 comments of Matthew Peveler

@sidorares I've rebased the PR onto the latest master.

Not sure why the build suite is failing here, and I don't know enough about Ruby ecosystem or this project to know where to start.

I would love to see the middle two as I think they are invaluable for seeders that deal with complex data and I had a use-case for them the other...

The decrease in code coverage is fine. Most likely some of the formatting changes made here touch upon code that's not tested.

Looking at this further, I think there's a question on what the expected behavior of a user when they do something like: ```php $this->adapter->renameTable('schema1.table1', 'schema2.table1'); ``` Where, right now, this...

> I think we should only use the table name without schema in the ALTER TABLE query. Yes, you have to. Otherwise postgres will throw an error. > If users...

> I think phinx could have a changeSchema that calls ALTER TABLE name SET SCHEMA schema. Does phinx have a way to create schemas already? If not, should this be...

Yup, got a patch cooking where it only fixes the rename in the case where the schema on the second argument matches the schema of the first argument. For example,...

What do you mean by "locked" here? Did you set some sort of [column security](https://stackoverflow.com/a/44314719) on this table that you're hitting? Not sure there is phinx related as it does...

Could you provide the following information? 1. What database adatper are you using (mysql, postgres, etc.)? 2. A list of affected migration file names (or at least the date part...