Matthew Peveler

Results 298 comments of Matthew Peveler

@bmcutler Are there any notifications like this around logins with the SAML system at RPI that you know of? @akshatbatra I don't think it's necessarily a bad idea. From your...

@shailpatels In production, we definitely still want this to be a hard fail / exception as otherwise I feel like we might hit later on failures that would be harder...

Sorry for the delay on looking at this, will try to get to this sometime this week.

Looks like Node: `'User-Agent': 'tldr-node-client',`

It might be that because `https://tldr-pages.github.io/assets/tldr.zip` is returning a 301, it messes up the client from getting it?

I would probably just make it the default that we construct the list of possible page locations, check if the page exists in any of them, and if it does,...

Are you able to change the following line: https://github.com/tldr-pages/tldr-python-client/blob/d8722698284e5adde7fc561ea1c0b6ab114df528/tldr.py#L490 to be: ```python colorama.init(strip=options.color, convert=True) ``` and see if that fixes the problem?

Alternatively, we may need to adjust it so that we do a `from sys import stdout` after calling `colorama.init()` to get it to work on Windows. I'm not totally sure,...

Getting to be quite a lot of environment variables, and time to have a configuration file instead, especially on adding more specific theming stuff. Might be good to look at...

Eh, for now, I'm fine with you just implementing these as new environment variables. I'll make a separate issue to track implementing `.tldrrc`. > What has more priority: environment variables...