node-mysql2 icon indicating copy to clipboard operation
node-mysql2 copied to clipboard

Expose authPlugins to enable example from docs

Open MasterOdin opened this issue 4 years ago • 2 comments

The example of using authPlugins given in https://github.com/sidorares/node-mysql2/blob/master/lib/auth_plugins/caching_sha2_password.md is not possible, as this module does not expose a top level authPlugin object. This PR adds that top-level object, as well as fully typing for the existing plugins.

MasterOdin avatar Jan 29 '22 03:01 MasterOdin

Not sure why the Windows tests are failing on a date test. That should be unrelated to this PR?

MasterOdin avatar Jan 29 '22 14:01 MasterOdin

@MasterOdin definitely unrelated, I saw that started to happening in other PRs. Need to investigate that

sidorares avatar Jan 29 '22 23:01 sidorares

@MasterOdin could you rebase please? I have accidentally merged code in the master that fails linter but that should be fixed now

sidorares avatar Nov 10 '22 23:11 sidorares

@sidorares I've rebased the PR onto the latest master.

MasterOdin avatar Nov 15 '22 18:11 MasterOdin

I don't believe perf issue is real, nothing in the PR can contribute to it. Likely a slower CI runner

sidorares avatar Nov 15 '22 23:11 sidorares