Martin

Results 95 comments of Martin

So, here is a full proposal. Feedback is appreciated. Either in the discussion #786, or per review.

Can this PR be merged? It is still a draft then and can still be changed, but at least we have a starting point.

Thanks. The PR targets now the folder `draft`. Is that correct? Or should it be `RFCs`? Or `preview`?

> we can just cache the contents keyed by filename Would we want to add another layer of complexity? I'd rather want to remove all file system access from the...

Yes, I think so. At some level (like `fsc` and `FSharpChecker`) of course we need to deal with file system IO. But not deep down in `range` or `CompilerDiagnostics`. I...

Yes, that's a way to do it. But the whole compiler core (parse, type check etc) works on whole files and cannot process local changes. So, I wonder why a...

> I was thinking more in the context of this issue. To properly map a range to a substring via `FileIndexTable` without touching the filesystem, we need to keep the...

> The IDE does not allocate a single large string every time you type a character. But something close to a string (something which can be read sequentially as a...