fslang-design icon indicating copy to clipboard operation
fslang-design copied to clipboard

FS-1146-scoped-nowarn RFC proposal

Open Martin521 opened this issue 1 year ago • 3 comments

RFC proposal for scoped nowarn. Click here to view the latest version. For discussions, #786 has been started.

Martin521 avatar Aug 07 '24 20:08 Martin521

So, here is a full proposal. Feedback is appreciated. Either in the discussion #786, or per review.

Martin521 avatar Aug 19 '24 15:08 Martin521

Heads up:

The following section will need a rewrite showing the logic and a few samples (I assume those can be taken from tests from the implementation PR once it lands):

https://learn.microsoft.com/en-us/dotnet/fsharp/language-reference/compiler-directives#preprocessor-directives

T-Gro avatar Sep 13 '24 09:09 T-Gro

Can this PR be merged? It is still a draft then and can still be changed, but at least we have a starting point.

Martin521 avatar Sep 29 '24 13:09 Martin521

@T-Gro @vzarytovskii If you get a chance could you assess and merge if you see fit? thanks

dsyme avatar Jan 19 '25 15:01 dsyme

This RFC looks good, it can be merged - the remaining comments are about preparing explicit single-place documentation for breaking changes.

T-Gro avatar Feb 12 '25 08:02 T-Gro

Thanks. The PR targets now the folder draft. Is that correct? Or should it be RFCs? Or preview?

Martin521 avatar Feb 12 '25 10:02 Martin521

Draft was OK initially, but please move it to https://github.com/fsharp/fslang-design/tree/main/RFCs now.

T-Gro avatar Feb 12 '25 10:02 T-Gro

done

Martin521 avatar Feb 12 '25 16:02 Martin521